Migrate tests for model serialization to goldens. #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is to ensure that whenever we change the model serialization code, it is much easier to update the tests. The changes should be more readable this way.
When code changes to request changes to the goldens, the author of the change will need to run a
pytest
command to update the files by passing a flag, then add the goldens to the PR (ideally via a new commit).This also ensures that we can test all models in all scenarios, in a similar way. Thus, removed the tests for empty models that were just testing for empty manifest. Added a new model that only contains an empty file.
Release Note
NONE
Documentation
NONE